Use Base.alloc_request instead of implementing it directly#1145
Open
Use Base.alloc_request instead of implementing it directly#1145
Conversation
There is slightly better error handling in this function, which avoids relying as directly on implementation details of IOBuffer
vtjnash
force-pushed
the
jn/alloc_request
branch
from
56c6531 to
b240a83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 82.67% 82.67% -0.01%
==========================================
Files 32 32
Lines 3054 3053 -1
==========================================
- Hits 2525 2524 -1
Misses 529 529 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is slightly better error handling in this function, which avoids relying as directly on implementation details of IOBuffer